[DTRA] Maryia/DTRA-1559/feat: add isVerticalScrollEnabled prop to disable vertical scroll outside Y-axis #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
changed the title
maryia-deriv
commented
Aug 5, 2024
| (((date as unknown) as number) - bar.DT!.getTime()) / | ||
| (bar.DT!.getTime() - barPrev.DT!.getTime()); | ||
| ((date as unknown as number) - (bar.DT as Date).getTime()) / | ||
| ((bar.DT as Date).getTime() - (barPrev.DT as Date).getTime()); |
There was a problem hiding this comment.
just fixing 'Forbidden non-null assertion' TS warning
kate-deriv
approved these changes
Aug 5, 2024
ahmadtaimoor-deriv
approved these changes
Aug 5, 2024
akmal-deriv
approved these changes
Aug 5, 2024
Co-authored-by: Akmal Djumakhodjaev <[email protected]>
kate-deriv
approved these changes
Aug 5, 2024
|
Preview Link: https://pr-1625-dtra.smartcharts-preview.pages.dev
|
vinu-deriv
approved these changes
Aug 5, 2024
akmal-deriv
approved these changes
Aug 6, 2024
balakrishna-deriv
approved these changes
Aug 6, 2024
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To introduce the new
isVerticalScrollEnabledprop which, when set tofalse, is working as follows: